Skip to content

Simplify Hardware into a Swift package - Sources only #15744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Simplify Hardware into a Swift package - Sources only #15744

merged 1 commit into from
Jun 19, 2025

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 13, 2025 •
edited
Loading

Description

See https://linear.app/a8c/issue/AINFRA-510.

Based on top of #15742 and based off the original work from #15678 .

This first PR moves the Storage sources from being a framework to being a Swift package. There is nothing noteworthy in the code.

Steps to reproduce & Testing information

See green CI. Also check out the prototype build.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. — N.A.

@mokagio mokagio added this to the 22.7 milestone Jun 13, 2025
@mokagio mokagio self-assigned this Jun 13, 2025
@mokagio mokagio added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Jun 13, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jun 13, 2025 •
edited
Loading

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 13, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30584
VersionPR #15744
Bundle IDcom.automattic.alpha.woocommerce
Commit8c82f5e
Installation URL0uhcre3ijtck0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio force-pushed the ainfra-510-hardware-sources branch 2 times, most recently from 67deb52 to 952948e Compare June 16, 2025 05:54
@mokagio mokagio mentioned this pull request Jun 16, 2025
Merged
1 task
@mokagio mokagio force-pushed the ainfra-469-storage-sources branch from 9e6eb7c to 85bf6ec Compare June 18, 2025 03:28
@mokagio mokagio force-pushed the ainfra-510-hardware-sources branch from 0aec18c to 9660145 Compare June 18, 2025 03:30
@mokagio mokagio mentioned this pull request Jun 18, 2025
Merged
1 task
mokagio
mokagio commented Jun 18, 2025
View reviewed changes
Hardware/Hardware.xcodeproj/xcshareddata/xcschemes/HardwareTests.xcscheme
buildConfiguration = "Release"
revealArchiveInOrganizer = "YES">
</ArchiveAction>
</Scheme>
Copy link
Contributor Author

@mokagio mokagio Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scheme is just a temporary clutch to run the tests in isolation. Once the tests become part of the package, it'll all be done via the package's scheme.

@mokagio mokagio force-pushed the ainfra-469-storage-sources branch from 85bf6ec to 4192a53 Compare June 18, 2025 10:38
@mokagio mokagio force-pushed the ainfra-510-hardware-sources branch from 9660145 to 7bdc4dd Compare June 18, 2025 10:40
@mokagio mokagio force-pushed the ainfra-469-storage-sources branch 2 times, most recently from 179b5dc to 176c9a8 Compare June 19, 2025 05:02
@mokagio mokagio force-pushed the ainfra-510-hardware-sources branch from 7bdc4dd to 8c82f5e Compare June 19, 2025 05:32
Base automatically changed from ainfra-469-storage-sources to trunk June 19, 2025 09:10
joshheald
joshheald approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested card payments on a simulator and building to the watch as well (which doesn't even use Hardware, but just in case... twice shy!)

@mokagio mokagio marked this pull request as ready for review June 19, 2025 23:48
@mokagio mokagio merged commit e94edaa into trunk Jun 19, 2025
15 checks passed
@mokagio mokagio deleted the ainfra-510-hardware-sources branch June 19, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshheald joshheald joshheald approved these changes

Assignees

@mokagio mokagio

Labels

category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.

Projects

None yet

Milestone

22.7

Development

Successfully merging this pull request may close these issues.

5 participants

@mokagio @dangermattic @wpmobilebot @joshheald